Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CosineAnnealingLR is missing #757

Merged
merged 9 commits into from
Nov 15, 2021
Merged

fix: CosineAnnealingLR is missing #757

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4988c8c
fix: CosineAnnealingLR is missing
hoangtnm Oct 23, 2021
c66c711
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 23, 2021
a6e0a6a
Update changelog
akihironitta Oct 26, 2021
b958d5d
Merge branch 'master' into patch-1
Borda Nov 8, 2021
1d7a461
Merge branch 'master' into patch-1
mergify[bot] Nov 8, 2021
9ab86ba
Merge branch 'master' into patch-1
mergify[bot] Nov 8, 2021
0082d6e
Merge branch 'master' into patch-1
mergify[bot] Nov 8, 2021
de78396
Merge branch 'master' into patch-1
mergify[bot] Nov 15, 2021
8165823
Merge branch 'master' into patch-1
mergify[bot] Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fix doctest fails with ImportError: cannot import name 'Env' from 'gym' ([#751](https://github.com/PyTorchLightning/lightning-bolts/pull/751))
- Fixed doctest fails with ImportError: cannot import name 'Env' from 'gym' ([#751](https://github.com/PyTorchLightning/lightning-bolts/pull/751))

- Fixed MoCo v2 missing Cosine Annealing learning scheduler ([#757](https://github.com/PyTorchLightning/lightning-bolts/pull/757))

## [0.4.0] - 2021-09-09

Expand Down
6 changes: 5 additions & 1 deletion pl_bolts/models/self_supervised/moco/moco2_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,11 @@ def configure_optimizers(self):
momentum=self.hparams.momentum,
weight_decay=self.hparams.weight_decay,
)
return optimizer
scheduler = torch.optim.lr_scheduler.CosineAnnealingLR(
optimizer,
self.trainer.max_epochs,
)
return [optimizer], [scheduler]

@staticmethod
def add_model_specific_args(parent_parser):
Expand Down