Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update experience_source.py #749 Bug Fix #751

Merged
merged 5 commits into from
Oct 15, 2021
Merged

Update experience_source.py #749 Bug Fix #751

merged 5 commits into from
Oct 15, 2021

Conversation

Programmer-RD-AI
Copy link
Contributor

@Programmer-RD-AI Programmer-RD-AI commented Oct 15, 2021 •
edited by akihironitta
Loading

What does this PR do?

This PR will stop the error

ImportError: cannot import name 'Env' from 'gym' (unknown location)

Hotfix for #749.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the datamodule Anything related to datamodules label Oct 15, 2021
akihironitta
akihironitta approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Programmer-RD-AI Thanks for sending this PR! As a hotfix, it looks good to me.

@akihironitta akihironitta added ci/cd Continues Integration and delivery documentation Improvements or additions to documentation and removed datamodule Anything related to datamodules labels Oct 15, 2021
akihironitta
akihironitta suggested changes Oct 15, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Borda Borda merged commit f4f6d53 into Lightning-Universe:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@akihironitta akihironitta akihironitta approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
ci/cd Continues Integration and delivery documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Programmer-RD-AI @Borda @akihironitta