Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppres warnings #617

Merged
merged 2 commits into from
Apr 8, 2021
Merged

suppres warnings #617

merged 2 commits into from
Apr 8, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 8, 2021

What does this PR do?

hide missing packages under os env var, requested by @williamFalcon

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #617 (f9bb7b4) into master (9044ed1) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head f9bb7b4 differs from pull request most recent head 2f73937. Consider uploading reports for the commit 2f73937 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   25.20%   25.11%   -0.09%     
==========================================
  Files         118      118              
  Lines        7119     7122       +3     
==========================================
- Hits         1794     1789       -5     
- Misses       5325     5333       +8     
Flag Coverage Δ
cpu 25.11% <100.00%> (-0.09%) ⬇️
pytest 25.11% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/utils/warnings.py 50.00% <100.00%> (-50.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9044ed1...2f73937. Read the comment docs.

@Borda Borda merged commit 35f6314 into master Apr 8, 2021
@Borda Borda deleted the warns branch April 8, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant