[Issue #578] Remove dependency of imagenet_dataset.py on torch._six #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The import PY3 from Torch._six no longer exists as of Torch PR #46579 - Updated to use PY37, which is the current only available import
Removed dependency on torch._six for checking if Python 3 is used. This relaxes the condition of Python >=3.7 if dependency is to be kept.
0xEljh
requested review from
akihironitta,
ananyahjha93 and
Borda
as code owners
Borda
approved these changes
Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Torch PR #46579, it is no longer possible to import PY3 from torch._six
This small change simply removes the dependency on torch._six for checking if Python 3 is used.
Fixes #578