Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TensorboardGenerativeModelImageSampler args #494

Conversation

chris-clem
Copy link
Contributor

@chris-clem chris-clem commented Jan 4, 2021

What does this PR do?

Updates TensorboardGenerativeModelImageSampler args as discussed in #489.

Fixes #489

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #494 (1bf5420) into master (42cfa8f) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   79.24%   79.06%   -0.18%     
==========================================
  Files         107      102       -5     
  Lines        6201     5919     -282     
==========================================
- Hits         4914     4680     -234     
+ Misses       1287     1239      -48     
Flag Coverage Δ
cpu 25.76% <18.18%> (-0.35%) ⬇️
pytest 25.76% <18.18%> (-0.35%) ⬇️
unittests 78.57% <100.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/callbacks/vision/image_generation.py 93.33% <100.00%> (+2.02%) ⬆️
pl_bolts/utils/__init__.py 100.00% <0.00%> (ø)
pl_bolts/callbacks/__init__.py 100.00% <0.00%> (ø)
pl_bolts/models/rl/dqn_model.py 78.98% <0.00%> (ø)
pl_bolts/models/self_supervised/__init__.py 100.00% <0.00%> (ø)
...l_bolts/models/self_supervised/swav/swav_resnet.py 70.20% <0.00%> (ø)
...bolts/models/self_supervised/amdim/amdim_module.py 96.73% <0.00%> (ø)
pl_bolts/callbacks/verification/batch_gradient.py
pl_bolts/callbacks/verification/base.py
...s/models/self_supervised/simsiam/simsiam_module.py
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42cfa8f...49a0cc8. Read the comment docs.

@chris-clem chris-clem marked this pull request as ready for review January 4, 2021 17:10
@chris-clem chris-clem changed the title Feature/489 update tensorboard generative model image sampler args Update TensorboardGenerativeModelImageSampler args Jan 4, 2021
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-clem Thank you for your swift action! Would you mind having a look at the below suggestions?

pl_bolts/callbacks/vision/image_generation.py Outdated Show resolved Hide resolved
pl_bolts/callbacks/vision/image_generation.py Outdated Show resolved Hide resolved
@akihironitta akihironitta self-assigned this Jan 5, 2021
@akihironitta akihironitta added callback enhancement New feature or request labels Jan 5, 2021
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-clem LGTM. Thank you!

@akihironitta
Copy link
Contributor

@Borda @ananyahjha93 Should we include the tests for this class in this PR? or later in another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nrow and normalize args to TensorboardGenerativeModelImageSampler
3 participants