Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SRGAN and datamodules for super resolution #466

Merged
merged 140 commits into from
Nov 26, 2021

Conversation

chris-clem
Copy link
Contributor

@chris-clem chris-clem commented Dec 20, 2020

What does this PR do?

Adds a SRGAN implementation to bolts as proposed in #412.

Closes #412

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?
  • Add train logs and example images

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Dec 20, 2020

Hello @chris-clem! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-12 07:10:48 UTC

@chris-clem chris-clem changed the title Feature/412 srgan Add SRGAN Module Dec 20, 2020
@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #466 (6bf356b) into master (b9b35c4) will increase coverage by 1%.
The diff coverage is 93%.

❗ Current head 6bf356b differs from pull request most recent head 376828d. Consider uploading reports for the commit 376828d to get more accurate results

@@          Coverage Diff           @@
##           master   #466    +/-   ##
======================================
+ Coverage      73%    74%    +1%     
======================================
  Files         128    134     +6     
  Lines        8461   8244   -217     
======================================
- Hits         6193   6102    -91     
+ Misses       2268   2142   -126     

@akihironitta akihironitta added this to In progress in AE & GANs via automation Dec 21, 2020
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-clem Hi, thanks for reminding me of this issue. I had a look at all the failing tests, and am sure that they are all irrelevant to the change in this PR :]

@akihironitta akihironitta changed the title [wip] Add SRGAN and datamodules for super resolution Add SRGAN and datamodules for super resolution Oct 3, 2021
@mergify mergify bot removed the ready label Oct 14, 2021
@mergify mergify bot added the has conflicts label Nov 8, 2021
@mergify mergify bot removed the has conflicts label Nov 8, 2021
@mergify mergify bot removed the has conflicts label Nov 26, 2021
@Borda Borda enabled auto-merge (squash) November 26, 2021 09:28
@Borda Borda modified the milestones: v0.4, v0.5 Nov 26, 2021
@chris-clem
Copy link
Contributor Author

@Borda @akihironitta Should I fix the CodeFactor and DeepSource issues?

@Borda
Copy link
Member

Borda commented Nov 26, 2021

@Borda @akihironitta Should I fix the CodeFactor and DeepSource issues?

I think it is fine :] just adding back mypy typing... #776

@Borda Borda merged commit ab11fe8 into Lightning-Universe:master Nov 26, 2021
AE & GANs automation moved this from in Review to Done Nov 26, 2021
@chris-clem chris-clem deleted the feature/412_srgan branch November 28, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules model ready
Projects
Development

Successfully merging this pull request may close these issues.

Add SRGAN
6 participants