Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cli arguments of models #394

Merged
merged 3 commits into from
Nov 22, 2020

Conversation

akihironitta
Copy link
Contributor

What does this PR do?

Changes --data_path to --data_dir which is commonly used in other models.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #394 (64cf526) into master (b8ac851) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files         100      100           
  Lines        5714     5714           
=======================================
  Hits         4639     4639           
  Misses       1075     1075           
Flag Coverage Δ
cpu 24.27% <ø> (ø)
pytest 24.27% <ø> (ø)
unittests 80.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../models/self_supervised/simclr/simclr_finetuner.py 100.00% <ø> (ø)
...lts/models/self_supervised/simclr/simclr_module.py 71.49% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ac851...95c1f85. Read the comment docs.

@akihironitta akihironitta changed the title Refactor cli arguments of models [wip] Refactor cli arguments of models Nov 22, 2020
@akihironitta akihironitta marked this pull request as ready for review November 22, 2020 05:59
@akihironitta akihironitta added this to In progress in Code Health / Refatoring via automation Nov 22, 2020
@Borda Borda added the enhancement New feature or request label Nov 22, 2020
@Borda Borda self-requested a review November 22, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Development

Successfully merging this pull request may close these issues.

None yet

2 participants