Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple DataModules from Models - SemSegment #332

Merged

Conversation

akihironitta
Copy link
Contributor

What does this PR do?

This PR is a follow up of #206 and fixes #207.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #332 (eff9150) into master (f00e85d) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   82.32%   82.40%   +0.07%     
==========================================
  Files         100      100              
  Lines        5602     5620      +18     
==========================================
+ Hits         4612     4631      +19     
+ Misses        990      989       -1     
Flag Coverage Δ
cpu 24.76% <0.00%> (+<0.01%) ⬆️
pytest 24.76% <0.00%> (+<0.01%) ⬆️
unittests 81.65% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/models/vision/segmentation.py 62.74% <0.00%> (-2.64%) ⬇️
pl_bolts/utils/arguments.py 96.15% <0.00%> (+0.04%) ⬆️
.../models/autoencoders/basic_vae/basic_vae_module.py 91.66% <0.00%> (+0.08%) ⬆️
pl_bolts/losses/self_supervised_learning.py 77.70% <0.00%> (+0.14%) ⬆️
...ts/models/autoencoders/basic_ae/basic_ae_module.py 88.00% <0.00%> (+0.16%) ⬆️
pl_bolts/models/rl/common/gym_wrappers.py 89.91% <0.00%> (+0.26%) ⬆️
pl_bolts/datasets/imagenet_dataset.py 18.45% <0.00%> (+0.38%) ⬆️
pl_bolts/optimizers/lars_scheduling.py 95.74% <0.00%> (+0.39%) ⬆️
..._bolts/models/self_supervised/moco/moco2_module.py 79.23% <0.00%> (+0.49%) ⬆️
pl_bolts/datasets/ssl_amdim_datasets.py 75.00% <0.00%> (+1.08%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00e85d...eff9150. Read the comment docs.

@Borda Borda added datamodule Anything related to datamodules refactoring labels Nov 6, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Borda
Copy link
Member

Borda commented Nov 6, 2020

@akihironitta seems that some tests are not passing, mind have a look... :]

@akihironitta
Copy link
Contributor Author

@Borda Thanks for the fix in #343. It seems to have passed the tests.

@Borda Borda added the ready label Nov 9, 2020
@Borda Borda merged commit 6895350 into Lightning-Universe:master Nov 9, 2020
@akihironitta akihironitta changed the title Decouple DataModules from Models - SegSegment Decouple DataModules from Models - SemSegment Nov 12, 2020
@akihironitta akihironitta deleted the decouple-dms/semsegment branch November 12, 2020 01:49
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules ready refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple DataModules from Models
2 participants