Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SSL hooks fro pl 1.0 #277

Merged
merged 2 commits into from
Oct 15, 2020
Merged

fix SSL hooks fro pl 1.0 #277

merged 2 commits into from
Oct 15, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 15, 2020

What does this PR do?

fix missing outputs in hooks

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added fix fixing issues... ci/cd Continues Integration and delivery labels Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #277 into master will increase coverage by 1.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   79.73%   80.86%   +1.13%     
==========================================
  Files          91       91              
  Lines        4840     4840              
==========================================
+ Hits         3859     3914      +55     
+ Misses        981      926      -55     
Flag Coverage Δ
#cpu 23.90% <100.00%> (ø)
#pytest 23.90% <100.00%> (ø)
#unittests 80.33% <100.00%> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/callbacks/vision/confused_logit.py 100.00% <ø> (ø)
pl_bolts/callbacks/self_supervised.py 69.56% <100.00%> (ø)
...ts/models/autoencoders/basic_ae/basic_ae_module.py 79.72% <0.00%> (+1.35%) ⬆️
pl_bolts/models/autoencoders/components.py 87.03% <0.00%> (+1.85%) ⬆️
pl_bolts/models/self_supervised/resnets.py 92.78% <0.00%> (+2.57%) ⬆️
.../models/autoencoders/basic_vae/basic_vae_module.py 85.10% <0.00%> (+3.19%) ⬆️
...l_bolts/models/self_supervised/byol/byol_module.py 80.64% <0.00%> (+6.45%) ⬆️
...lts/models/self_supervised/simclr/simclr_module.py 82.81% <0.00%> (+7.03%) ⬆️
pl_bolts/models/self_supervised/evaluator.py 94.44% <0.00%> (+11.11%) ⬆️
...bolts/models/self_supervised/amdim/amdim_module.py 82.97% <0.00%> (+26.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccdc9f9...d73b68b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continues Integration and delivery fix fixing issues...
Development

Successfully merging this pull request may close these issues.

None yet

1 participant