Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move datasets to existing package #275

Merged
merged 2 commits into from
Oct 14, 2020
Merged

move datasets to existing package #275

merged 2 commits into from
Oct 14, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 14, 2020

What does this PR do?

There is already package datasets with just Dummy datasets, so lets move all datasets there...
TODO: think why we need to name all datasets in file name when it is already in folder name
import pl_bolts.datasets.mnist_dataset ?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #275 into master will decrease coverage by 2.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   82.46%   79.90%   -2.57%     
==========================================
  Files          89       91       +2     
  Lines        4664     4841     +177     
==========================================
+ Hits         3846     3868      +22     
- Misses        818      973     +155     
Flag Coverage Δ
#cpu 23.92% <25.00%> (-1.34%) ⬇️
#pytest 23.92% <25.00%> (-1.34%) ⬇️
#unittests 79.36% <100.00%> (-2.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/datasets/base_dataset.py 95.45% <ø> (ø)
pl_bolts/datasets/concat_dataset.py 41.66% <ø> (ø)
pl_bolts/datasets/imagenet_dataset.py 18.78% <ø> (ø)
pl_bolts/datasets/kitti_dataset.py 30.43% <ø> (ø)
pl_bolts/datasets/mnist_dataset.py 42.85% <ø> (ø)
pl_bolts/datasets/ssl_amdim_datasets.py 73.23% <ø> (ø)
pl_bolts/datamodules/__init__.py 100.00% <100.00%> (ø)
pl_bolts/datasets/cifar10_dataset.py 96.80% <100.00%> (ø)
pl_bolts/models/self_supervised/amdim/datasets.py 60.37% <100.00%> (ø)
...ts/models/autoencoders/basic_ae/basic_ae_module.py 79.72% <0.00%> (-8.11%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fd35b...8cc06b6. Read the comment docs.

@Borda Borda marked this pull request as ready for review October 14, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant