Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set min requirements PL 1.0 #274

Merged
merged 1 commit into from
Oct 13, 2020
Merged

set min requirements PL 1.0 #274

merged 1 commit into from
Oct 13, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 13, 2020

What does this PR do?

Set min req. PL 1.0

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Oct 13, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #274 into master will decrease coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
- Coverage   83.25%   82.01%   -1.25%     
==========================================
  Files          89       89              
  Lines        4664     4664              
==========================================
- Hits         3883     3825      -58     
- Misses        781      839      +58     
Flag Coverage Δ
#cpu 25.25% <ø> (ø)
#pytest 25.25% <ø> (ø)
#unittests 81.45% <ø> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/callbacks/self_supervised.py 69.56% <0.00%> (-30.44%) ⬇️
...bolts/models/self_supervised/amdim/amdim_module.py 56.38% <0.00%> (-26.60%) ⬇️
pl_bolts/models/self_supervised/evaluator.py 83.33% <0.00%> (-11.12%) ⬇️
...l_bolts/models/self_supervised/byol/byol_module.py 74.19% <0.00%> (-10.76%) ⬇️
...lts/models/self_supervised/simclr/simclr_module.py 75.78% <0.00%> (-7.04%) ⬇️
pl_bolts/models/self_supervised/resnets.py 90.20% <0.00%> (-2.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e3376...052729e. Read the comment docs.

@williamFalcon
Copy link
Contributor

why is coverage dropped?

@Borda
Copy link
Member Author

Borda commented Oct 13, 2020

why is coverage dropped?

because we have falling tests, so the complete report is missing and now codecov was only resulting from docstrings inside the package, also ignoring all data modules

@Borda
Copy link
Member Author

Borda commented Oct 13, 2020

checked are the failing tests are the same as on the master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants