add eks tab to infer #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themattinthehatt
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Looks good! One more request - let's give the user the ability to (partially) name their ensemble. I imagine a text box below the model selection dropdown, and the default text is "eks". If we name the output of this textbox "ensemble_name", then the eks folder path can be
eks_folder_path = os.path.join(state.proj_dir[1:], MODELS_DIR, f"{dtime}_{ensemble_name}")
We should also do
ensemble_name = ensemble_name.replace(" ", "_")
right after the textbox.
themattinthehatt
approved these changes
Apr 11, 2024
themattinthehatt
merged commit e4386a6
into
Lightning-Universe:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.