Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add names for uses & norm spaces #78

Merged
merged 5 commits into from
Dec 19, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/cache/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ runs:
python -c "from pip._internal.locations import USER_CACHE_DIR; print('PIP_CACHE_DIR=' + USER_CACHE_DIR)" >> $GITHUB_ENV
shell: bash

- name: Cache pip
- name: Cache 💽 pip
uses: actions/cache@v3
with:
path: $PIP_CACHE_DIR
key: ${{ runner.os }}-py${{ inputs.python-version }}-pip-${{ inputs.offset }}-${{ hashFiles('requirements.txt') }}
restore-keys: ${{ runner.os }}-py${{ inputs.python-version }}-pip-${{ inputs.offset }}-

- name: Cache conda
- name: Cache 💽 conda
uses: actions/cache@v3
if: runner.os == 'Linux'
with:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/check-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
mypy:
runs-on: ubuntu-20.04
steps:
- name: Checkout
- name: Checkout 🛎️
uses: actions/checkout@v3

- name: Set up Python ${{ inputs.python-version }}
- name: Set up Python 🐍 ${{ inputs.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ inputs.python-version }}
Expand Down Expand Up @@ -46,20 +46,20 @@ jobs:
pre-commit:
runs-on: ubuntu-20.04
steps:
- name: Checkout
- name: Checkout 🛎️
Borda marked this conversation as resolved.
Show resolved Hide resolved
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Set up Python
- name: Set up Python 🐍
uses: actions/setup-python@v4
with:
python-version: ${{ inputs.python-version }}

- name: Determine cache hash
run: echo "PY=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV

- name: Cache pre-commit
- name: Cache 💽 pre-commit
uses: actions/cache@v3
with:
path: ~/.cache/pre-commit
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/check-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ jobs:
runs-on: ubuntu-20.04

steps:
- name: Checkout
- name: Checkout 🛎
uses: actions/checkout@v3

- name: Set up Python ${{ inputs.python-version }}
- name: Set up Python 🐍 ${{ inputs.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ inputs.python-version }}
Expand Down Expand Up @@ -62,10 +62,10 @@ jobs:
runs-on: ubuntu-20.04

steps:
- name: Checkout
- name: Checkout 🛎
uses: actions/checkout@v3

- name: Set up Python ${{ inputs.python-version }}
- name: Set up Python 🐍 ${{ inputs.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ inputs.python-version }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
matrix: ${{ fromJSON(inputs.strategy-matrix) }}

steps:
- name: Checkout
- name: Checkout 🛎
uses: actions/checkout@v3

- name: Set up Python ${{ matrix.python-version }}
- name: Set up Python 🐍 ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
schema:
runs-on: ubuntu-20.04
steps:
- name: Checkout
- name: Checkout 🛎
uses: actions/checkout@v3

- name: Install dependencies
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/ci-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ jobs:
timeout-minutes: 35

steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
- name: Checkout 🛎
uses: actions/checkout@v3
- name: Set up Python 🐍 ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
Expand All @@ -32,7 +33,8 @@ jobs:
pip install -e '.[cli]'
python -m lightning_utilities.cli requirements set-oldest

- uses: ./.github/actions/cache
- name: Complex 💽 caching
uses: ./.github/actions/cache
with:
python-version: ${{ matrix.python-version }}

Expand All @@ -47,7 +49,8 @@ jobs:
# TODO: re-enable after the external usage is resolved, see #51
# - uses: ./.github/actions/pip-list

- uses: ./.github/actions/unittesting
- name: Unittesting and coverage
uses: ./.github/actions/unittesting
with:
python-version: ${{ matrix.python-version }}
pytorch-version: ${{ matrix.pytorch-version }}
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/docs-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ jobs:
# If you're using actions/checkout@v3 you must set persist-credentials to false in most cases for the deployment to work correctly.
with:
persist-credentials: false
- uses: actions/setup-python@v4
with:
- name: Set up Python 🐍
uses: actions/setup-python@v4
with:
python-version: 3.7

# Note: This uses an internal pip API and may not always work
# https://github.com/actions/cache/blob/master/examples.md#multiple-oss-in-a-workflow
- name: Cache pip
- name: Cache 💽 pip
uses: actions/cache@v3
with:
path: ~/.cache/pip
Expand Down
21 changes: 14 additions & 7 deletions .github/workflows/publish-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ jobs:
runs-on: ubuntu-20.04
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
- name: Checkout 🛎️
uses: actions/checkout@v3
- name: Set up Python 🐍
uses: actions/setup-python@v4
with:
python-version: 3.8

Expand All @@ -26,7 +28,8 @@ jobs:
python setup.py sdist bdist_wheel
ls -lh dist/

- uses: actions/upload-artifact@v3
- name: Upload 📤 artifact
uses: actions/upload-artifact@v3
with:
name: pypi-packages-${{ github.sha }}
path: dist
Expand All @@ -36,8 +39,10 @@ jobs:
runs-on: ubuntu-20.04
needs: build-package
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
- name: Checkout 🛎️
uses: actions/checkout@v3
- name: Download 📥 artifact
uses: actions/download-artifact@v3
with:
name: pypi-packages-${{ github.sha }}
path: dist
Expand All @@ -55,8 +60,10 @@ jobs:
timeout-minutes: 10
needs: build-package
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
- name: Checkout 🛎️
uses: actions/checkout@v3
- name: Download 📥 artifact
uses: actions/download-artifact@v3
with:
name: pypi-packages-${{ github.sha }}
path: dist
Expand Down