Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add names for uses & norm spaces #78

Merged
merged 5 commits into from
Dec 19, 2022
Merged

add names for uses & norm spaces #78

merged 5 commits into from
Dec 19, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 19, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

add names to all uses in actions

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci/cd Continuous integration and delivery label Dec 19, 2022
@Borda Borda requested review from ethanwharris and a team December 19, 2022 10:13
@Borda Borda enabled auto-merge (squash) December 19, 2022 10:13
akihironitta
akihironitta approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 🔔 🐍 💿

.github/workflows/check-code.yml Show resolved Hide resolved
Borda and others added 3 commits December 19, 2022 11:32
@Borda Borda requested review from a team and carmocca December 19, 2022 10:38
@Borda Borda changed the title add names for uses add names for uses & norm spaces Dec 19, 2022
@Borda Borda merged commit 661018a into main Dec 19, 2022
@Borda Borda deleted the ci/names branch December 19, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
ci/cd Continuous integration and delivery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @akihironitta