Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _filter_kwargs method to ClasswiseWrapper for better integration with MetricCollection #2575

Merged
merged 9 commits into from
Jun 5, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 31, 2024

What does this PR do?

Fixes #2542

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2575.org.readthedocs.build/en/2575/

@SkafteNicki SkafteNicki added the enhancement New feature or request label May 31, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36%. Comparing base (8172c58) to head (ec6b4e6).
Report is 95 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2575     +/-   ##
========================================
- Coverage      69%     36%    -33%     
========================================
  Files         314     314             
  Lines       17700   17702      +2     
========================================
- Hits        12198    6423   -5775     
- Misses       5502   11279   +5777     

@mergify mergify bot added the ready label May 31, 2024
@stancld stancld enabled auto-merge (squash) June 3, 2024 19:14
@mergify mergify bot removed the ready label Jun 4, 2024
@mergify mergify bot added the ready label Jun 4, 2024
@stancld stancld merged commit bf0d6e2 into master Jun 5, 2024
61 checks passed
@stancld stancld deleted the feature/classwise_filter_kwargs branch June 5, 2024 10:35
Borda pushed a commit that referenced this pull request Aug 2, 2024
…ion with `MetricCollection` (#2575)

(cherry picked from commit bf0d6e2)
Borda pushed a commit that referenced this pull request Aug 2, 2024
…ion with `MetricCollection` (#2575)

(cherry picked from commit bf0d6e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add _filter_kwargs in ClasswiseWrapper metric wrapper
3 participants