Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eps in UniversalQualityIndex #2222

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Move eps in UniversalQualityIndex #2222

merged 4 commits into from
Nov 21, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 19, 2023

What does this PR do?

Fixes #2221

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2222.org.readthedocs.build/en/2222/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Nov 19, 2023
@SkafteNicki SkafteNicki added this to the v1.2.x milestone Nov 19, 2023
@SkafteNicki SkafteNicki self-assigned this Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Merging #2222 (875f980) into master (28ac2b2) will decrease coverage by 47%.
Report is 3 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2222     +/-   ##
========================================
- Coverage      87%     40%    -47%     
========================================
  Files         293     293             
  Lines       16414   16425     +11     
========================================
- Hits        14270    6639   -7631     
- Misses       2144    9786   +7642     

@mergify mergify bot added the ready label Nov 19, 2023
@Borda Borda merged commit bcf7867 into master Nov 21, 2023
22 of 31 checks passed
@Borda Borda deleted the stability_in_uqi branch November 21, 2023 14:30
Borda pushed a commit that referenced this pull request Nov 30, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit bcf7867)
Borda pushed a commit that referenced this pull request Dec 1, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit bcf7867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready topic: Image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UniversalImageQualityIndex & SpectralDistortionIndex are still possible to give NaN results
2 participants