-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in specificity_at_sensitivity
#2199
Conversation
ordered similarly, duplicates removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it si breaking change but worse to fix it
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2199 +/- ##
========================================
- Coverage 87% 47% -39%
========================================
Files 293 293
Lines 16437 16469 +32
========================================
- Hits 14275 7807 -6468
- Misses 2162 8662 +6500 |
@Borda To avoid any misunderstandings among other reviewers, could you please clarify your comment? I assume you mean: "It is not a breaking change, but it is worth fixing." Am I correct? |
Head branch was pushed to by a user without write access
src/torchmetrics/functional/classification/specificity_sensitivity.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/classification/specificity_sensitivity.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/classification/specificity_sensitivity.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
specificity_at_sensitivity
…vity.py Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
for more information, see https://pre-commit.ci
What does this PR do?
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
📚 Documentation preview 📚: https://torchmetrics--2199.org.readthedocs.build/en/2199/