Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in specificity_at_sensitivity #2199

Merged
merged 20 commits into from
Nov 29, 2023
Merged

Conversation

oguz-hanoglu
Copy link
Contributor

@oguz-hanoglu oguz-hanoglu commented Nov 2, 2023

What does this PR do?

  • specicity used instead of specificity -> Fixed.
  • The issue was: init.py has duplicates (class based one), init.py's are not organized in the same order (functional and class based)
  • The issue addressed as removing duplicates and reorganizing the list order.
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

  • Make sure you had fun coding 🙃

📚 Documentation preview 📚: https://torchmetrics--2199.org.readthedocs.build/en/2199/

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it si breaking change but worse to fix it

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2199 (3fea3fa) into master (245ee24) will decrease coverage by 39%.
Report is 1 commits behind head on master.
The diff coverage is 51%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2199     +/-   ##
========================================
- Coverage      87%     47%    -39%     
========================================
  Files         293     293             
  Lines       16437   16469     +32     
========================================
- Hits        14275    7807   -6468     
- Misses       2162    8662   +6500     

@mergify mergify bot added the ready label Nov 2, 2023
@Borda Borda enabled auto-merge (squash) November 2, 2023 15:29
@oguz-hanoglu
Copy link
Contributor Author

@Borda To avoid any misunderstandings among other reviewers, could you please clarify your comment? I assume you mean: "It is not a breaking change, but it is worth fixing." Am I correct?

@Borda Borda requested a review from a team November 15, 2023 10:12
@mergify mergify bot removed the ready label Nov 23, 2023
auto-merge was automatically disabled November 23, 2023 12:33

Head branch was pushed to by a user without write access

@Borda Borda changed the title Typo Fix and init.py organization fix typo in specificity_at_sensitivity Nov 28, 2023
SkafteNicki and others added 2 commits November 28, 2023 17:16
…vity.py

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
@mergify mergify bot removed the has conflicts label Nov 28, 2023
@Borda Borda enabled auto-merge (squash) November 28, 2023 16:31
@Borda Borda requested a review from lantiga November 28, 2023 16:31
@mergify mergify bot added the ready label Nov 28, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Nov 28, 2023
@Borda Borda merged commit b7f74c2 into Lightning-AI:master Nov 29, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants