Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch plotting order for pr curves #2183

Merged
merged 5 commits into from
Nov 18, 2023
Merged

Switch plotting order for pr curves #2183

merged 5 commits into from
Nov 18, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 17, 2023

What does this PR do?

Fixes #2161
Switch order to be consistent with scikit-learn

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2183.org.readthedocs.build/en/2183/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Oct 17, 2023
@SkafteNicki SkafteNicki added this to the v1.2.x milestone Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2183 (b83aaa7) into master (28ac2b2) will decrease coverage by 39%.
The diff coverage is 0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2183     +/-   ##
========================================
- Coverage      87%     47%    -39%     
========================================
  Files         293     293             
  Lines       16411   16417      +6     
========================================
- Hits        14267    7798   -6469     
- Misses       2144    8619   +6475     

@mergify mergify bot added the ready label Oct 17, 2023
@Borda Borda enabled auto-merge (squash) October 24, 2023 16:02
@Borda Borda requested a review from a team November 15, 2023 10:12
@Borda Borda merged commit beae928 into master Nov 18, 2023
61 checks passed
@Borda Borda deleted the plot/pr_curve_switch_axis branch November 18, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precision-Recall Curve: switch axes in plot
3 participants