Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump testing for PT 2.1 #2142

Merged
merged 30 commits into from
Oct 10, 2023
Merged

bump testing for PT 2.1 #2142

merged 30 commits into from
Oct 10, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 4, 2023

What does this PR do?

https://dev-discuss.pytorch.org/t/pytorch-release-2-1-0/1271

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2142.org.readthedocs.build/en/2142/

@Borda
Copy link
Member Author

Borda commented Oct 4, 2023

let's wait for resolving the py3.11 in #2138

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2142 (d912b6b) into master (5e58398) will increase coverage by 0%.
The diff coverage is 88%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2142   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         293     293           
  Lines       16428   16430    +2     
======================================
+ Hits        14284   14286    +2     
  Misses       2144    2144           

@SkafteNicki SkafteNicki added the test / CI testing or CI label Oct 5, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Oct 5, 2023
@mergify mergify bot added the has conflicts label Oct 6, 2023
@mergify mergify bot removed the has conflicts label Oct 6, 2023
@Borda Borda added the Important milestonish label Oct 6, 2023
@Borda Borda enabled auto-merge (squash) October 6, 2023 18:17
@Borda Borda mentioned this pull request Oct 6, 2023
4 tasks
@mergify mergify bot added the ready label Oct 8, 2023
@Borda Borda requested a review from a team October 8, 2023 23:38
@mergify mergify bot added the has conflicts label Oct 9, 2023
@mergify mergify bot removed the has conflicts label Oct 9, 2023
@Borda
Copy link
Member Author

Borda commented Oct 9, 2023

@SkafteNicki seems to be failing on Win + pt2.1
unittests\image\test_perceptual_path_length.py::test_sim_net

@mergify mergify bot removed the has conflicts label Oct 10, 2023
@Borda Borda disabled auto-merge October 10, 2023 17:11
@Borda Borda merged commit 5c6b23c into master Oct 10, 2023
77 checks passed
@Borda Borda deleted the bump/torch-2.1 branch October 10, 2023 17:12
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Oct 14, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: stancld <daniel.stancl@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda added a commit that referenced this pull request Nov 30, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: stancld <daniel.stancl@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

(cherry picked from commit 5c6b23c)
Borda added a commit that referenced this pull request Dec 1, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: stancld <daniel.stancl@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

(cherry picked from commit 5c6b23c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants