Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v0.9 integration with PL #1058

Merged
merged 8 commits into from
Jun 7, 2022
Merged

Fix v0.9 integration with PL #1058

merged 8 commits into from
Jun 7, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jun 1, 2022 •
edited
Loading

What does this PR do?

Fixes #1064
Removed the v0.9 warning if user override forward themself (like we do in PL).

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022 •
edited
Loading

Codecov Report

Merging #1058 (5ff7aad) into master (3856db4) will increase coverage by 0%.
The diff coverage is 70%.

@@          Coverage Diff           @@
##           master   #1058   +/-   ##
======================================
  Coverage      94%     95%           
======================================
  Files         181     181           
  Lines        8010    8029   +19     
======================================
+ Hits         7553    7601   +48     
+ Misses        457     428   -29

@mergify mergify bot added the ready label Jun 1, 2022
@Borda Borda enabled auto-merge (squash) June 2, 2022 11:09
carmocca
carmocca approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comments about utilities

torchmetrics/metric.py Outdated Show resolved Hide resolved
tests/bases/test_metric.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the ready label Jun 3, 2022
@SkafteNicki SkafteNicki mentioned this pull request Jun 5, 2022
Closed
@mergify mergify bot added the ready label Jun 6, 2022
@Borda Borda disabled auto-merge June 6, 2022 12:29
@Borda Borda enabled auto-merge (squash) June 6, 2022 12:30
@Borda Borda merged commit c04090b into master Jun 7, 2022
@Borda Borda deleted the bugfix/no_warning_custom_warning branch June 7, 2022 08:50
@Borda Borda added this to the v0.9 milestone Jun 7, 2022
@tcoln
Copy link

tcoln commented Jul 8, 2022

The warnings apper in v0.92 again.

@djdameln djdameln mentioned this pull request Aug 31, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock justusschock approved these changes

@tchaton tchaton Awaiting requested review from tchaton

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees
No one assigned
Labels
bug / fix Something isn't working ready
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

UserWarning at functional confusion_matrix function
6 participants
@SkafteNicki @tcoln @awaelchli @Borda @carmocca @justusschock