Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Hints for Lightning Core #946

Merged
merged 38 commits into from
Mar 12, 2020
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
661405d
first pass for LightningModule typehints
Feb 23, 2020
9b5e784
fix return types
Feb 23, 2020
dc89b90
add missing types
Feb 25, 2020
d3460cb
add type annotations to grads.py
Feb 25, 2020
cdfd1d1
add type annotations to hooks.py
Feb 25, 2020
3526a77
add type annotation to memory.py
Feb 25, 2020
614256c
proper docstring quotation marks
Feb 25, 2020
e36f42a
add type annotations to saving.py
Feb 25, 2020
0c86afe
fix cyclic import problem
Feb 25, 2020
280a0d0
fix cyclic import problem
Feb 25, 2020
e433490
add missing whitespace
Feb 25, 2020
4d24fdf
finish type hints for load_from_ methods
Feb 26, 2020
c2e1cec
docs: prepare_data does not return anything
Feb 26, 2020
a878adb
fix auto types in docs
Feb 26, 2020
35eb67c
revert typehint for trainer in hook
Feb 26, 2020
0272309
remove unnecessary return docs
Feb 26, 2020
34f7c7d
some fixes for memory docs
Feb 26, 2020
2fa525f
revert typing for args kwargs
Feb 26, 2020
1187ef7
added all missing None return types
Feb 26, 2020
fe19508
remove unused import
Feb 26, 2020
02e50c3
add more details to dict/list return types
Feb 26, 2020
d11f747
fix line too long
Feb 27, 2020
bee44d0
optimize imports
Mar 3, 2020
09b8c16
Merge branch 'master' into module-typehints
Borda Mar 5, 2020
8555961
linted
Borda Mar 5, 2020
7482cb8
Revert "linted"
Borda Mar 5, 2020
cad32d8
remove whitespace
Mar 5, 2020
ced9435
Merge branch 'master' into module-typehints
Mar 6, 2020
b3f0ba5
update
Mar 7, 2020
aef5138
Merge branch 'master' into module-typehints
Mar 7, 2020
15516de
update
Mar 7, 2020
9c026ce
update
Mar 7, 2020
2915e6b
update
Mar 7, 2020
4bd0437
update
Mar 7, 2020
5c4b27f
Merge branch 'master' into module-typehints
Mar 10, 2020
4f68fc1
changelog
Mar 10, 2020
4a517c3
Merge branch 'master' into module-typehints
Mar 11, 2020
1909bad
Merge branch 'master' into module-typehints
williamFalcon Mar 12, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch_lightning/core/saving.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def on_hpc_load(self, checkpoint: Dict[str, Any]) -> None:
Hook to do whatever you need right before Slurm manager loads the model
"""


awaelchli marked this conversation as resolved.
Show resolved Hide resolved
Borda marked this conversation as resolved.
Show resolved Hide resolved
def load_hparams_from_tags_csv(tags_csv: str) -> Namespace:
if not os.path.isfile(tags_csv):
log.warning(f'Missing Tags: {tags_csv}.')
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.