add python 3.8 testing #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2020
Closed
Borda
changed the title
|
@Borda how's this going |
|
lets keep this for future,
note it is not scheduled for any milestone... |
Borda
changed the title
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
=====================================
Coverage 92% 92%
=====================================
Files 62 62
Lines 3210 3210
=====================================
Hits 2949 2949
Misses 261 261 |
Borda
changed the title
|
@Borda is this dead? |
|
no, just resumed, it was blocked by #986 which was merged right now... |
|
seems that PyTorch 1.1 does not exist for py3.8 is, the minimal version is 1.2 |
justusschock
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #910. I have run CI for 3.8 and it seems that not all packages are ported to 3.8 yet, e.g.
torchvisionWhich comes we shall droptorchvisioneven from test dependencies #859 #942 #986PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃