Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning_cache.deprecation and set warning stacklevel [1/2] #8005

Merged
merged 3 commits into from
Jun 18, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Jun 16, 2021

What does this PR do?

Ran an example in Lightning Flash. Was bombarded with this warning.

Before submitting

  • [] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [] Did you make sure to update the documentation with your changes? (if necessary)
  • [] Did you write any new necessary tests? (not for typos and docs)
  • [] Did you verify new and existing tests pass locally with your changes?
  • [] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #8005 (a8882e9) into master (bc2c2db) will decrease coverage by 5%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #8005    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         207     207            
  Lines       13374   13494   +120     
=======================================
- Hits        12246   11722   -524     
- Misses       1128    1772   +644     

@justusschock
Copy link
Member

@kaushikb11 I think #8002 should already resolve this since there rank_zero_deprecation makes also use of the cache!

@kaushikb11
Copy link
Contributor Author

@carmocca Would #8002 resolve this issue?

@carmocca
Copy link
Contributor

rank_zero_deprecation makes also use of the cache

Not really, but I added warning_cache.deprecation which uses rank_zero_deprecation

Would #8002 resolve this issue?

Yes, but let's fix this separately here. Pushing some changes

@carmocca carmocca changed the title Use warning cache for lightning.datamodule warning Add warning_cache.deprecation and set warning stacklevel Jun 18, 2021
@carmocca carmocca changed the title Add warning_cache.deprecation and set warning stacklevel Add warning_cache.deprecation and set warning stacklevel [1/2] Jun 18, 2021
@carmocca carmocca added this to the v1.3.x milestone Jun 18, 2021
@carmocca carmocca added the bug Something isn't working label Jun 18, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you find the solution independently? nice coincidence, @carmocca and me kinda found the same peculiar warning behavior

@carmocca
Copy link
Contributor

nice coincidence, @carmocca and me kinda found the same peculiar warning behavior

Not a coincidence. I updated the PR 😆

@carmocca carmocca enabled auto-merge (squash) June 18, 2021 11:42
@carmocca carmocca merged commit f447839 into Lightning-AI:master Jun 18, 2021
awaelchli added a commit that referenced this pull request Jun 22, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Jun 22, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants