-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually show deprecation warnings and their line level [2/2] #8002
Conversation
…n sterr." This reverts commit 5814213.
Codecov Report
@@ Coverage Diff @@
## master #8002 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 207 210 +3
Lines 13497 13590 +93
=======================================
- Hits 12367 11821 -546
- Misses 1130 1769 +639 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fully convinced about splitting up the the rank_zero functions but if circular imports are trouble, ok sounds fair :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
What does this PR do?
Issue
DeprecationWarnings weren't being shown for two reasons:
Solution
LightningDeprecationWarning
and enable itwarnings.py
To decide
Since
DeprecationWarning
s haven't been shown, we need to decide if we should delay their removal versions.Option 👀 : do nothing - an argument is that we already mention what's been deprecated in the release notes
Option 🚀 : Only delay the removal version of warnings set to be removed in 1.4
Option ❤️ : Do it for all
Before submitting
PR review