Resolve some codefactor issues #756
Conversation
broke tests, because bool is actually subclass of int
|
GPU tests also pass, except amp which I don't have and ddp2 which needs SLURM and I don't have that. |
tests/test_restore_models.py
Outdated
| @@ -58,9 +58,9 @@ def test_running_test_pretrained_model_ddp(tmpdir): | |||
|
|
|||
|
|
|||
| def test_running_test_pretrained_model(tmpdir): | |||
| """Verify test() on pretrained model""" | |||
There was a problem hiding this comment.
with the docs, a sentence should end with "."
Borda
added
feature
|
@awaelchli could you pls rebase master... |
broke tests, because bool is actually subclass of int
|
@awaelchli btw, you may check also the codacy issues in another PR... |
|
yes I may take a look at these later. |
|
I d love to see it too... I have asked @williamFalcon for adding codefactor here, creating PTL account because actually there is just my fork... |
|
@awaelchli rebase? |
* move logging >> loggers * add warning * fix tests * logging alias * formatting * formatting
* add more detail to tbptt example * warn user about new arg in training_step
broke tests, because bool is actually subclass of int
|
@williamFalcon rebased |
|
@williamFalcon could you create PyTorch-Lightning account on www.codefactor.io? but it seems that it allows login with a GH account... or we may switch to www.Codacy.com which supports organisations... |
Before submitting
What does this PR do?
Fixes issues that codefactor is complaining about. See all issues here.
I only looked at the easy ones and did not touch anything complex.
If you are not happy with some of the changes, let me know and I will revert these.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃