Change nb to num in ABCs, comments, and tqdm logging #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Borda
approved these changes
Dec 8, 2019
pytorch_lightning/trainer/logging.py
Outdated
| @@ -177,7 +177,7 @@ def reduce_distributed_output(self, output, num_gpus): | |||
| elif isinstance(output[k], torch.Tensor) and output[k].dim() == 0: | |||
| pass | |||
|
|
|||
| # reduce only metrics that have the same nb of gpus | |||
| # reduce only metrics that have the same num of gpus | |||
| @@ -169,22 +170,22 @@ class TrainerTrainLoopMixin(ABC): | |||
| def __init__(self): | |||
| # this is just a summary on variables used in this abstract class, | |||
| # the proper values/initialisation should be done in child class | |||
| self.max_nb_epochs = None | |||
| self.max_epochs = None | |||
| self.min_epochs = None | |||
There was a problem hiding this comment.
is the min needed here in this class?
There was a problem hiding this comment.
yes, it is used in the training loop.
There was a problem hiding this comment.
self.min_nb_epochs was there before, just lower down in the list, so I moved it up so it would be next to self.max_epochs.
| @property | ||
| def max_nb_epochs(self): | ||
| """ | ||
| .. warning:: `max_nb_epochs` is deprecated and will be removed in |
I think so. I did a project-wide search for "nb" and these were all the remaining ones I found, other than the ones used for SLURM, since SLURM uses "nb" in some of their variables. |
|
I updated this PR with the suggestions by @Borda if someone wants to rereview it or merge it if it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #589 (comment)