Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find actual minimal requirements #546

Closed
wants to merge 2 commits into from
Closed

find actual minimal requirements #546

wants to merge 2 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 25, 2019

What does this PR do?

Find the minimal requirements that let tests pass. In follow-up PR we shall recover back compatibility with PyTorch 1.1 and 1.2

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@Borda
Copy link
Member Author

Borda commented Nov 25, 2019

@williamFalcon I think that this is an important step to let all other work on this project smoothly going... and then in parallel we can recover older versions...

@williamFalcon
Copy link
Contributor

@Borda sorry we can't do this. We need to recover 1.1 and 1.2 as the most immediate priority

@Borda
Copy link
Member Author

Borda commented Nov 25, 2019

I understand, I just propose to do it step by step, not in a single large effort...
so the next one is lower to 1.2 with all test passing and then 1.1...

@williamFalcon
Copy link
Contributor

williamFalcon commented Nov 25, 2019

ok that makes sense. Can we prioritize that for now? The next release will need to be pushed back if we can't support 1.1 or 1.2.

But still, I don't want to auto-upgrade these packages for people. So let's keep it as is and submit the fixes one by one, otherwise people working on master are going to get a surprise when their environments upgrade automatically.

So, let' close this PR and submit new ones for 1.2 and 1.1 support.

@Borda
Copy link
Member Author

Borda commented Nov 25, 2019

ok that makes sense.

@williamFalcon well, I thought that you merge it, but instead, you closed it 😞

Can we prioritize that for now? The next release will need to be pushed back if we can't support 1.1 or 1.2.

just working on it...

@Borda Borda deleted the pt_1-3 branch November 25, 2019 22:49
This was referenced Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants