Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring #2884

Merged
merged 2 commits into from Aug 8, 2020
Merged

Fix docstring #2884

merged 2 commits into from Aug 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2020

"mean absolute loss" rather than "root mean absolute loss"

"mean absolute loss" rather than "root mean absolute loss"
@mergify mergify bot requested a review from a team August 8, 2020 10:20
@rohitgr7
Copy link
Contributor

rohitgr7 commented Aug 8, 2020

reduction docstring is also wrong in most of these metrics in regression, classification, and functional as well. I would suggest it to be 'a method for reducing metric score over labels' for all.

@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #2884 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2884   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          79      79           
  Lines        7236    7236           
======================================
  Hits         6530    6530           
  Misses        706     706           

@Borda Borda added ready PRs ready to be merged docs Documentation related and removed ready PRs ready to be merged labels Aug 8, 2020
@mergify mergify bot requested a review from a team August 8, 2020 10:51
@awaelchli
Copy link
Member

@rohitgr7 PR? 🤩

@mergify mergify bot requested a review from a team August 8, 2020 11:01
@mergify mergify bot merged commit 6ebe0d7 into Lightning-AI:master Aug 8, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2020

Great job! =)

@Borda Borda added this to the 0.9.0 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants