Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accumulate_grad_batches for last batch #2853

Merged
merged 18 commits into from
Aug 15, 2020
Merged

Fix accumulate_grad_batches for last batch #2853

merged 18 commits into from
Aug 15, 2020

Commits on Aug 8, 2020

  1. first attempt

    ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    954a870 View commit details
    Browse the repository at this point in the history

  2. update changelog

    ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    7265aa5 View commit details
    Browse the repository at this point in the history

  3. fix pep8 and tests

    ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    b33bef8 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
    @Borda @rohitgr7
    2 people authored and ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    a53f224 View commit details
    Browse the repository at this point in the history

  5. added new tests

    ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    09c0a08 View commit details
    Browse the repository at this point in the history

  6. fixed tests

    ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    a675ba4 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review

    @Borda
    Borda authored and ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    df917cc View commit details
    Browse the repository at this point in the history

  8. used num_training_batches

    ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    e3218e8 View commit details
    Browse the repository at this point in the history

  9. fixed pep8

    ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    266ad45 View commit details
    Browse the repository at this point in the history

  10. fixed with is_last_batch suggested by @awaelchli

    ydcjeff committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    c3d2fc3 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2020

  1. fixed with num_training_batches

    ydcjeff committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    8993183 View commit details
    Browse the repository at this point in the history

  2. fixed with num_training_batches

    ydcjeff committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    a8ae40d View commit details
    Browse the repository at this point in the history

  3. cleanup

    ydcjeff committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    2b514f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. fix test and update docs

    ydcjeff committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    dcfc880 View commit details
    Browse the repository at this point in the history

  2. fixed for alignment, update docs

    ydcjeff committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    1e86ad3 View commit details
    Browse the repository at this point in the history

  3. minor changes

    @rohitgr7
    rohitgr7 committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    694e07e View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2020

  1. update doc

    @awaelchli
    awaelchli committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    a8b82d6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into HEAD

    @rohitgr7
    rohitgr7 committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    ac4f4c0 View commit details
    Browse the repository at this point in the history