Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] title clarification in Results page #2827

Merged
merged 3 commits into from
Aug 5, 2020
Merged

[DOCS] title clarification in Results page #2827

merged 3 commits into from
Aug 5, 2020

Conversation

romesco
Copy link
Contributor

@romesco romesco commented Aug 4, 2020

What does this PR do?

Clarifies that test loop is equivalent to validation loop in terms of return objects.

Fixes #1936

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 4, 2020 21:39
@romesco romesco mentioned this pull request Aug 4, 2020
@romesco romesco changed the title title tweak DOCS: title clarification in Results page Aug 4, 2020
@romesco romesco changed the title DOCS: title clarification in Results page [DOCS] title clarification in Results page Aug 4, 2020
@Borda Borda added the docs Documentation related label Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #2827 into master will increase coverage by 31%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2827     +/-   ##
========================================
+ Coverage      59%     90%    +31%     
========================================
  Files          78      78             
  Lines        6918    6921      +3     
========================================
+ Hits         4071    6238   +2167     
+ Misses       2847     683   -2164     

@mergify mergify bot requested a review from a team August 5, 2020 15:45
@mergify mergify bot requested a review from a team August 5, 2020 16:39
@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2020

Great job! =)

@Borda Borda merged commit d09098c into Lightning-AI:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"test_loss" in test step
5 participants