Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"test_loss" in test step #1936

Closed
hminle opened this issue May 24, 2020 · 9 comments · Fixed by #2827
Closed

"test_loss" in test step #1936

hminle opened this issue May 24, 2020 · 9 comments · Fixed by #2827
Labels
docs Documentation related good first issue Good for newcomers

Comments

@hminle
Copy link

hminle commented May 24, 2020

Hi PL team,

🚀 Feature

image
I see in the test step, we should return "test_loss" instead of "val_loss".
It will become clearer.

Thanks

@hminle hminle added feature Is an improvement or enhancement help wanted Open to be worked on labels May 24, 2020
@github-actions
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@awaelchli
Copy link
Member

could you point us to the link you found this?

@awaelchli awaelchli added docs Documentation related and removed feature Is an improvement or enhancement help wanted Open to be worked on labels May 24, 2020
@hminle
Copy link
Author

hminle commented May 24, 2020

could you point us to the link you found this?

Hi @awaelchli ,
Here you are: https://pytorch-lightning.readthedocs.io/en/stable/introduction_guide.html#testing

@stale
Copy link

stale bot commented Jul 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jul 24, 2020
@awaelchli
Copy link
Member

ok, this will probably anyway be overwritten by the docs in part 3 of #2615 structured results.

@stale stale bot removed the won't fix This will not be worked on label Jul 24, 2020
@Borda
Copy link
Member

Borda commented Aug 4, 2020

@hminle mind send a PR?

@Borda Borda added the good first issue Good for newcomers label Aug 4, 2020
@romesco
Copy link
Contributor

romesco commented Aug 4, 2020

This docs fix was overwritten in latest which now recommends returning an EvalResult object: https://pytorch-lightning.readthedocs.io/en/latest/introduction_guide.html#testing

The relevant info is now in:
https://pytorch-lightning.readthedocs.io/en/latest/results.html

I made a PR to clarify that the validation loop paragraph is also applicable to the test_loop.
#2827

@awaelchli
Copy link
Member

nice thank you!

@hminle
Copy link
Author

hminle commented Aug 13, 2020

Thank guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants