Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs update and follow up of #2789 #2797

Merged
merged 5 commits into from
Aug 3, 2020
Merged

docs update and follow up of #2789 #2797

merged 5 commits into from
Aug 3, 2020

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 2, 2020

What does this PR do?

docs update for #2789 (comment)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Aug 2, 2020

Hello @rohitgr7! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-03 19:42:15 UTC

@mergify mergify bot requested a review from a team August 2, 2020 11:05
@Borda Borda added the docs Documentation related label Aug 2, 2020
@mergify mergify bot requested a review from a team August 3, 2020 18:35
@mergify mergify bot requested a review from a team August 3, 2020 18:41
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #2797 into master will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #2797    +/-   ##
=======================================
  Coverage      90%     90%            
=======================================
  Files          78      78            
  Lines        6979    6831   -148     
=======================================
- Hits         6258    6139   -119     
+ Misses        721     692    -29     

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2020

Great job! =)

@mergify mergify bot merged commit 6b9c548 into master Aug 3, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2020

Great job! =)

@rohitgr7 rohitgr7 deleted the docs_update branch August 3, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants