Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/torchtext include lengths #2689

Merged
merged 44 commits into from
Jul 31, 2020
Merged

Bugfix/torchtext include lengths #2689

merged 44 commits into from
Jul 31, 2020

Commits on Jul 24, 2020

  1. Test using torchtext.data.Field with include_lengths=True/False

    Thomas Schaaf committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    924e4c1 View commit details
    Browse the repository at this point in the history

  2. Fix issue that Tensors in a Batch generated by torchtext with torchte… 

    …xt.data.Field configured as include_lengths=True
    Thomas Schaaf committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    1fcbe36 View commit details
    Browse the repository at this point in the history

  3. Add description for fix of issue Lightning-AI#2688

    Thomas Schaaf committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    59e97b2 View commit details
    Browse the repository at this point in the history

  4. changes to accomodate CodeFactor issues

    Thomas Schaaf committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    3e3fbbe View commit details
    Browse the repository at this point in the history

  5. Another attemt to make last CodeFactor issue pass (it's a false alarm)

    Thomas Schaaf committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    fe9816d View commit details
    Browse the repository at this point in the history

  6. temporarly disable test of test_grad_tracking to check if testing wil… 

    …l pass
    Thomas Schaaf committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    957ee89 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2020

  1. reenable test in test_grad_norm

    Thomas Schaaf committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    7971e7d View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2020

  1. Update CHANGELOG.md 

    Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
    @thschaaf @Borda
    thschaaf and Borda committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    4d0a849 View commit details
    Browse the repository at this point in the history

  2. Renamed get_torchtext_data_iterator to _get_torchtext_data_iterator a… 

    …s suggested by @Borda
    Thomas Schaaf committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    c994e88 View commit details
    Browse the repository at this point in the history

  3. Update pytorch_lightning/utilities/apply_func.py 

    Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
    @thschaaf @awaelchli
    thschaaf and awaelchli committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    f60613c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. adding tests more specific to batch_move_data_to_device with tochtext… 

    … Batch
    Thomas Schaaf committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    c9fdf50 View commit details
    Browse the repository at this point in the history

  2. added check that Tensors were moved to target device

    Thomas Schaaf committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    5e568ea View commit details
    Browse the repository at this point in the history

  3. removed tests using RNN models to be moved into a separate PR

    Thomas Schaaf committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    a6b96b0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into bugfix/torchtext-include_lengths

    @thschaaf
    thschaaf committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    0eabe91 View commit details
    Browse the repository at this point in the history

  5. fixing FLAKE8 errors that showed up after merge from master branch 

    	modified:   tests/base/datamodules.py
	modified:   tests/callbacks/test_model_checkpoint.py
    Thomas Schaaf committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    398ab54 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into bugfix/torchtext-include_lengths

    @thschaaf
    thschaaf committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    8d56dc8 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. parameterized test to reduce code duplication

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    a99fc7d View commit details
    Browse the repository at this point in the history

  2. Added check only if length tensor exist. Removed left over comments.

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    61e692f View commit details
    Browse the repository at this point in the history

  3. rearranged device parameterization and added pytest.param

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    0c25f43 View commit details
    Browse the repository at this point in the history

  4. Try to figure out why only one device is tested on Linux machines

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f08dd78 View commit details
    Browse the repository at this point in the history

  5. Testing on CPU and GPU devices (GPU test is skip if no cuda device is… 

    … available.
    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    d2c4598 View commit details
    Browse the repository at this point in the history

  6. added test for TPU device (experimental)

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    9bd3854 View commit details
    Browse the repository at this point in the history

  7. Adding test parameterization for TPU test (experimental)

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    d04c288 View commit details
    Browse the repository at this point in the history

  8. change import statement to limit what is imported for a TPU environment

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    cca6ff3 View commit details
    Browse the repository at this point in the history

  9. made test work with TPU

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    5f3680d View commit details
    Browse the repository at this point in the history

  10. Change to trigger CI

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    08ebb6d View commit details
    Browse the repository at this point in the history

  11. Change to trigger CI

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    fa6b2f9 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'bugfix/torchtext-include_lengths' of https://github.com… 

    …/thschaaf/pytorch-lightning into bugfix/torchtext-include_lengths
    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f9d9887 View commit details
    Browse the repository at this point in the history

  13. uncommented TPU test to check CI

    Thomas Schaaf committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    940c34d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. reenabling TPU test

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    584328a View commit details
    Browse the repository at this point in the history

  2. small change to trigger CI build

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    ae71b14 View commit details
    Browse the repository at this point in the history

  3. small change to trigger CI build

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    34201bc View commit details
    Browse the repository at this point in the history

  4. small change to trigger CI build

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    a53a469 View commit details
    Browse the repository at this point in the history

  5. adding tests/utilities/test_apply_func_torchtext.py to CI TPU test

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    647e44b View commit details
    Browse the repository at this point in the history

  6. try to make test not skipped on CI with TPU

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    ff080da View commit details
    Browse the repository at this point in the history

  7. remove testing on TPU

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    43a5ea9 View commit details
    Browse the repository at this point in the history

  8. undo an accidental change to test_tpu.py (file should not have been t… 

    …ouched)
    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    73583c1 View commit details
    Browse the repository at this point in the history

  9. small change to trigger CI build

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    b929711 View commit details
    Browse the repository at this point in the history

  10. small change to trigger CI build

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    68e2152 View commit details
    Browse the repository at this point in the history

  11. Update tests/utilities/test_apply_func_torchtext.py

    @awaelchli
    awaelchli committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    c97cd69 View commit details
    Browse the repository at this point in the history

  12. Revert to previous version

    Thomas Schaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    1685077 View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from code review

    @Borda
    Borda committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    8a7d68b View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' into bugfix/torchtext-include_lengths

    @thschaaf
    thschaaf committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    72f64ad View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Change to trigger CI

    Thomas Schaaf committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    3c04090 View commit details
    Browse the repository at this point in the history