Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weights_save_path when logger is used + simplify path handling + better docs #2681

Merged
merged 24 commits into from
Jul 27, 2020
Merged

Fix weights_save_path when logger is used + simplify path handling + better docs #2681

merged 24 commits into from
Jul 27, 2020

Commits on Jul 23, 2020

  1. fix weights_save path and drop ckpt_path

    @awaelchli
    awaelchli committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    d9cac4c View commit details
    Browse the repository at this point in the history

  2. add tests

    @awaelchli
    awaelchli committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    924a997 View commit details
    Browse the repository at this point in the history

  3. unused import

    @awaelchli
    awaelchli committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    e0d2c5a View commit details
    Browse the repository at this point in the history

  4. update docs

    @awaelchli
    awaelchli committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    7583661 View commit details
    Browse the repository at this point in the history

  5. changelog

    @awaelchli
    awaelchli committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    9f60af3 View commit details
    Browse the repository at this point in the history

  6. pep8

    @awaelchli
    awaelchli committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    f91b0f7 View commit details
    Browse the repository at this point in the history

  7. fix horovod test

    @awaelchli
    awaelchli committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    2807458 View commit details
    Browse the repository at this point in the history

  8. make backward compatible

    @awaelchli
    awaelchli committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    e727794 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. perform same test for all loggers

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    c8dfffe View commit details
    Browse the repository at this point in the history

  2. fix for when logger=False and weights_save_path is set

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    a18e7f2 View commit details
    Browse the repository at this point in the history

  3. update changelog

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    2112b5c View commit details
    Browse the repository at this point in the history

  4. update docs

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    3ebd952 View commit details
    Browse the repository at this point in the history

  5. update tests

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    047ed63 View commit details
    Browse the repository at this point in the history

  6. do not set save dir dynamically

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    5dbee1e View commit details
    Browse the repository at this point in the history

  7. remove duplicate test

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    cb5636b View commit details
    Browse the repository at this point in the history

  8. remove duplicated tests

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    dd3ee40 View commit details
    Browse the repository at this point in the history

  9. update tests

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    7b87d5c View commit details
    Browse the repository at this point in the history

  10. update tests

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    5c5bcc9 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'tests/duplicate_tests' into bugfix/ckpt_path

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    5f8208a View commit details
    Browse the repository at this point in the history

  12. remove remaining ckpt_path references

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    1f17b1a View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into bugfix/ckpt_path

    @awaelchli
    awaelchli committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    33955e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2020

  1. move defaults to init as suggested by @Borda

    @awaelchli
    awaelchli committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    f6930eb View commit details
    Browse the repository at this point in the history

  2. test deprecation

    @awaelchli
    awaelchli committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    9c44f18 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2020

  1. Merge branch 'master' into bugfix/ckpt_path

    @awaelchli
    awaelchli committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    06eb18b View commit details
    Browse the repository at this point in the history