Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix num_batches with fast_dev_run & multiple test dataloaders #2661

Closed
wants to merge 1 commit into from

Conversation

lebrice
Copy link

@lebrice lebrice commented Jul 21, 2020

Fixed a small bug that seems to happen when using fast_dev_run and multiple
test dataloaders.

Signed-off-by: Fabrice Normandin fabrice.normandin@gmail.com

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Fixed a small bug that seems to happen when using fast_dev_run and multiple
test dataloaders.

Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@mergify mergify bot requested a review from a team July 21, 2020 19:11
@lebrice
Copy link
Author

lebrice commented Jul 21, 2020

Please don't accept this yet, or please convert it to a Draft, I'm still experiencing the issue. Will update this when its fixed
Ok false alarm, this commit does indeed resolve the issue for me after all.

@williamFalcon williamFalcon changed the title Fix num_batches with fast_dev_run & multiple test dataloaders [WIP] Fix num_batches with fast_dev_run & multiple test dataloaders Jul 21, 2020
@rohitgr7
Copy link
Contributor

Duplicate #2581?

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #2661 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2661   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files          72      72           
  Lines        6129    6129           
======================================
  Hits         5597    5597           
  Misses        532     532           

@awaelchli awaelchli added the duplicate This issue or pull request already exists label Jul 21, 2020
@lebrice
Copy link
Author

lebrice commented Jul 21, 2020

Ok false alarm, this commit does indeed resolve the issue for me after all.

@rohitgr7 It does seem like it might be a duplicate of #2581 , with this one being a one-line fix without the proper documentation and tests.
Feel free to close this PR if you want.

@lebrice lebrice changed the title [WIP] Fix num_batches with fast_dev_run & multiple test dataloaders Fix num_batches with fast_dev_run & multiple test dataloaders Jul 21, 2020
@rohitgr7
Copy link
Contributor

Nothing much. Needed to add some test with fast_dev_run, not possible by explicitly changing num_batches with fast_dev_run. Also removed some lines by explicitly changing limit_{mode)_batches in __init__.

@awaelchli awaelchli removed the duplicate This issue or pull request already exists label Jul 21, 2020
@williamFalcon
Copy link
Contributor

duplicate was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants