move torchtext as optional #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
added
bug
7 tasks
awaelchli
requested changes
Jun 27, 2020
awaelchli
reviewed
Jun 27, 2020
Comment on lines
94
to
96
| if Batch is None: | ||
| raise ImportError('You want to use `torchtext` package which is not installed yet,' | ||
| ' install it with `pip install torchtext`.') |
There was a problem hiding this comment.
this is incorrect, it will show the message to users that don't use torchtext. we need to wrap the logic here with TORCHTEXT AVAILABLE.
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
|
@Borda sorry about missing the dep in the previous PR! can we merge ASAP? |
|
@awaelchli good to go? |
awaelchli
approved these changes
Jun 28, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2379 (comment)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃