tests: add default_root_dir=tmpdir

[Borda]

What does this PR do?

some test were influenced by previous runs...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[Borda]

Not sure why MLFlow fails in CI while locally pass

        file_path = os.path.join(root, file_name)
        if not exists(file_path):
>           raise MissingConfigException("Yaml file '%s' does not exist." % file_path)
E           mlflow.exceptions.MissingConfigException: Yaml file '/tmp/pytest-of-runner/pytest-0/test_loggers_fit_test_MLFlowLo0/default/a7c4907de41943a7b958534289a872a2/meta.yaml' does not exist.

[awaelchli]

same here #2391 what's going on? I've been trying to debug this for literally almost the whole day.
I think it is a mismatch between the logger dir (weights_save_path) and the checkpoint dir .

[Borda]

@awaelchli so yo say that weights_save_path and default_root_dir does not like each other?

[awaelchli]

yes, the bug is somewhere burried in the many if else statements that sets these two variables. There seems to be a mismatch betwen these two paths.
Basically some loggers (e.g. mlflow) save a config file like meta.yaml in the log dir and this seems to be in the wrong folder.
Then when you try to resume from checkpoint (e.g. in trainer.test) it will not find that file.

[Borda]

yes, the bug is somewhere burried in the many if else statements that sets these two variables. There seems to be a mismatch betwen these two paths.

at first I thought just to skip it and use the passing test maybe it is a chance to find the bug and fix it...

[mergify]

This pull request is now in conflict... :(

[mergify]

This pull request is now in conflict... :(

[awaelchli]

@Borda #2502 got merged, this is now unblocked

[codecov]

Codecov Report

Merging #2392 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2392   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files          82      82           
  Lines        6784    6784           
======================================
  Hits         6151    6151           
  Misses        633     633           

[Borda]

@awaelchli thx for fixing missed changes after rebase :]

[jeremyjordan]

LGTM 👍
excited for this PR, those lingering test artifacts are definitely annoying