Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lost compatibility with custom datatypes implementing .to #2335

Merged
merged 6 commits into from
Jun 24, 2020

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Jun 23, 2020

What does this PR do?

Fixes #2314

When I refactored the data transfer and added a model hook in #1756, I accidentally removed the ability to move non-tensor datastructures that implement .to(). This PR re-enables that via a duck typing check. For this type of data, the user is not required to override the hook, since PL can handle this out of the box now.

The test alone fails on master, confirming that the changes here fix the bug.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Jun 23, 2020
@mergify mergify bot requested a review from a team June 23, 2020 21:18
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #2335 into master will decrease coverage by 0%.
The diff coverage is 90%.

@@          Coverage Diff           @@
##           master   #2335   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files          70      70           
  Lines        5512    5519    +7     
======================================
+ Hits         4851    4857    +6     
- Misses        661     662    +1     

@@ -38,14 +39,43 @@ def apply_to_collection(data: Any, dtype: Union[type, tuple], function: Callable
return data


class TransferableDataType(ABC):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case someone has a suggestion for a better name, let me know :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williamFalcon williamFalcon merged commit aab9e77 into master Jun 24, 2020
@williamFalcon
Copy link
Contributor

nice! great catch

@Borda Borda deleted the bugfix/to_device branch June 24, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking compatibility with custom datatypes implementing .to
3 participants