Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing test for "multiple dataloader + percent_check fix" #2226

Merged
merged 31 commits into from
Jun 23, 2020
Merged

Add missing test for "multiple dataloader + percent_check fix" #2226

merged 31 commits into from
Jun 23, 2020

Commits on Jun 17, 2020

  1. Init fix num_batches

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    ad833fa View commit details
    Browse the repository at this point in the history

  2. Fix num_batches in case of multiple dataloaders

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    7de06cc View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @awaelchli @Borda
    awaelchli authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    a9b996d View commit details
    Browse the repository at this point in the history

  4. Changes based on suggestions

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    da4fbcc View commit details
    Browse the repository at this point in the history

  5. Flake8

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    13bb5c0 View commit details
    Browse the repository at this point in the history

  6. Add test to check num_batches

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    5241bcb View commit details
    Browse the repository at this point in the history

  7. generalize dataloader percent check test

    @awaelchli @Borda
    awaelchli authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    98b59a4 View commit details
    Browse the repository at this point in the history

  8. fix formatting

    @awaelchli @Borda
    awaelchli authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    e0bd090 View commit details
    Browse the repository at this point in the history

  9. remove hparams

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f61c2c5 View commit details
    Browse the repository at this point in the history

  10. tests

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1aee122 View commit details
    Browse the repository at this point in the history

  11. CHANGELOG

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    c96e00a View commit details
    Browse the repository at this point in the history

  12. Update CHANGELOG.md

    @Borda
    Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    476a693 View commit details
    Browse the repository at this point in the history

  13. max_batches can be int

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    a7f751e View commit details
    Browse the repository at this point in the history

  14. conflict and rebase

    @rohitgr7 @Borda
    rohitgr7 authored and Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    4e033aa View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' into fix_num_batches_new

    @awaelchli
    awaelchli committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    46ab176 View commit details
    Browse the repository at this point in the history

  16. add back the test 

    fix


fix message


0.0 works


Revert "fix message"

This reverts commit 839cacf8b8610f4e697e654ef6f3d2501bf23984.
    @awaelchli
    awaelchli committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    06d5ab0 View commit details
    Browse the repository at this point in the history

  17. update changelog

    @awaelchli
    awaelchli committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    29f222c View commit details
    Browse the repository at this point in the history

  18. Update CHANGELOG.md

    @Borda
    Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    db84ca9 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Fix num batches in case of multiple dataloaders and percent_check (#1920 

    )

* git conflict

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
    @rohitgr7 @Borda @awaelchli
    3 people committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    4cc7223 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_num_batches_new

    @awaelchli
    awaelchli committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    c9f61b4 View commit details
    Browse the repository at this point in the history

  3. missing union

    @awaelchli
    awaelchli committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    bd4cb16 View commit details
    Browse the repository at this point in the history

  4. doc update suggestion by @rohitgr7

    @awaelchli
    awaelchli committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    3ad692f View commit details
    Browse the repository at this point in the history

  5. extend test

    @awaelchli
    awaelchli committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    28a8fe8 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix_num_batches_new

    @awaelchli
    awaelchli committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    d683a40 View commit details
    Browse the repository at this point in the history

  7. changelog

    @awaelchli
    awaelchli committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    f866dce View commit details
    Browse the repository at this point in the history

  8. docs add note about multiple loaders

    @awaelchli
    awaelchli committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    2320661 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. Merge branch 'master' into fix_num_batches_new

    @awaelchli
    awaelchli committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    0914464 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @awaelchli
    awaelchli committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    2bf631a View commit details
    Browse the repository at this point in the history

  3. remove unused variable

    @awaelchli
    awaelchli committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    005b45e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix_num_batches_new

    @awaelchli
    awaelchli committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    e9acd33 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. Merge branch 'master' into num_batches_missing_test

    @Borda
    Borda committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    3450180 View commit details
    Browse the repository at this point in the history