Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace train_percent_check with limit_train_batches #2220

Merged
merged 42 commits into from
Jun 17, 2020
Merged

replace train_percent_check with limit_train_batches #2220

merged 42 commits into from
Jun 17, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Jun 17, 2020 •
edited by Borda
Loading

Fixes #2213

@mergify mergify bot requested a review from a team June 17, 2020 12:33
@mergify mergify bot requested a review from a team June 17, 2020 12:55
@Borda Borda added bug Something isn't working priority: 0 High priority task labels Jun 17, 2020
@williamFalcon williamFalcon mentioned this pull request Jun 17, 2020
Closed
@mergify mergify bot requested a review from a team June 17, 2020 14:22
@Borda Borda mentioned this pull request Jun 17, 2020
Merged
5 tasks
@Lightning-AI Lightning-AI deleted a comment from williamFalcon Jun 17, 2020
Borda
Borda reviewed Jun 17, 2020
View reviewed changes
pytorch_lightning/callbacks/early_stopping.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/lr_logger.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team June 17, 2020 14:50
@williamFalcon williamFalcon mentioned this pull request Jun 17, 2020
Merged
@pep8speaks
Copy link

pep8speaks commented Jun 17, 2020 •
edited
Loading

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-17 16:56:14 UTC

@Borda Borda added this to the 0.8.0 milestone Jun 17, 2020
@williamFalcon williamFalcon merged commit 2411c3b into master Jun 17, 2020
@Borda Borda deleted the pct_check branch June 17, 2020 17:45
@Borda Borda added the docs Documentation related label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

Assignees
No one assigned
Labels
bug Something isn't working docs Documentation related priority: 0 High priority task
Projects
None yet
Milestone
pl:0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@williamFalcon @pep8speaks @Borda