enable prepare_data from correct processes - clarify local vs global rank #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-13 02:57:12 UTC |
williamFalcon
changed the title
williamFalcon
requested review from
awaelchli,
Borda,
jeremyjordan,
justusschock and
tullie
tullie
approved these changes
Jun 13, 2020
5 tasks
awaelchli
reviewed
Jun 13, 2020
| @@ -532,6 +542,7 @@ def get_init_arguments_and_types(cls) -> List[Tuple[str, Tuple, Any]]: | |||
| ('max_epochs', (<class 'int'>,), 1000), | |||
| ... | |||
| ('precision', (<class 'int'>,), 32), | |||
| ('prepare_data_per_node', (<class 'bool'>,), True), | |||
There was a problem hiding this comment.
it is in the wrong position. it should go after auto_scale_batch, which is not listed here. so the solution is to remove it.
also you removed
doctest: +ELLIPSIS +NORMALIZE_WHITESPACE
which I am fairly confident is needed
There was a problem hiding this comment.
what is it here?
if i remove it, it still fails
There was a problem hiding this comment.
well maybe I was wrong and it is just the missing +ELLIPSIS +NORMALIZE_WHITESPACE
cloned and doctest runs locally.
so i think its ok now
Borda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1878
Fixes #2163