update hparams, allow OmegaConf #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omry
reviewed
Jun 3, 2020
5 tasks
|
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-07 20:56:24 UTC |
Borda
requested review from
awaelchli,
jeremyjordan,
justusschock,
tullie and
williamFalcon
|
it seems that the loading is a bit tricky as we need to separate from saving a single config and multiple primitives... in particular, the multiple primitives are aggregated to an internal dict which may be the same as passed single dict config... so these two use-cases need to be saved separately 🐰 |
|
dropped duplicated tests and removed test from a past feature about collecting init args |
|
@omry @awaelchli @williamFalcon mind check the last version... |
omry
reviewed
Jun 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #2047 +/- ##
======================================
- Coverage 86% 86% -0%
======================================
Files 75 75
Lines 4710 4786 +76
======================================
+ Hits 4067 4129 +62
- Misses 643 657 +14 |
Co-authored-by: Omry Yadan <omry@fb.com>
Borda
changed the title
This was referenced Jun 11, 2020
justusschock
pushed a commit
that referenced
this pull request
Jun 29, 2020
* DictConf * inits * Apply suggestions from code review Co-authored-by: Omry Yadan <omry@fb.com> * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * atrib * wip * wip * wip * added hparams test * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Update test_hparams.py * added hparams test * added hparams test * pep8 * pep8 * pep8 * docs * wip * wip * clean * review @omry * Update docs/source/hyperparameters.rst Co-authored-by: Omry Yadan <omry@fb.com> Co-authored-by: Omry Yadan <omry@fb.com> Co-authored-by: William Falcon <waf2107@columbia.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2027
Fixes #2040
Fixes #2087
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃