Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toma comments to auto_scale_batch_size #1994

Merged
merged 2 commits into from
May 29, 2020

Conversation

BlackHC
Copy link
Contributor

@BlackHC BlackHC commented May 28, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Add links to toma in the auto_scale_batch_size as discussed in #1638.
Also, (for me as copyright holder) grant license for the used source code for this project under its own license instead of toma's MIT license.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

👍

@mergify mergify bot requested a review from a team May 28, 2020 22:01
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #1994 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1994   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          74      74           
  Lines        4641    4641           
======================================
  Hits         4064    4064           
  Misses        577     577           

@Borda Borda added the docs Documentation related label May 28, 2020
@mergify mergify bot requested a review from a team May 28, 2020 22:37
@Borda Borda added this to the 0.8.0 milestone May 28, 2020
@Borda Borda added the ready PRs ready to be merged label May 28, 2020
@mergify mergify bot requested a review from a team May 29, 2020 05:49
@mergify mergify bot merged commit 3af3f37 into Lightning-AI:master May 29, 2020
@mergify
Copy link
Contributor

mergify bot commented May 29, 2020

Great job! =)

justusschock pushed a commit that referenced this pull request Jun 29, 2020
* Add source comments

* Update training_tricks.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants