Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Confusion matrix and IoU #1971

Closed
wants to merge 1 commit into from

Conversation

kumuji
Copy link
Contributor

@kumuji kumuji commented May 27, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Draft that is trying to fix #1302 , #1299 , potentially #1295 , since TP, FP and FN can be extracted from confusion matrix

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@kumuji kumuji changed the title [WIP] draft for confusion matrix [WIP] Confusion matrix and IoU May 27, 2020
@mergify mergify bot requested a review from a team May 27, 2020 14:17
@kumuji kumuji marked this pull request as draft May 27, 2020 14:19
@kumuji
Copy link
Contributor Author

kumuji commented May 27, 2020

Oops, I saw in #1488 it is already done.

@kumuji kumuji closed this May 27, 2020
@justusschock
Copy link
Member

yes, and also this is not a pure torch metric. If you want to implement those, make sure, to always use TensorMetric and work on pure torch tensors (specifically no numpy!) We got the numpy versions in #1327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics: Confusion Matrix
2 participants