Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax issue #1900

Merged
merged 1 commit into from
May 20, 2020
Merged

fix syntax issue #1900

merged 1 commit into from
May 20, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented May 20, 2020

What does this PR do?

Fixes Github action syntax issue from #1877

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added priority: 0 High priority task ci Continuous Integration labels May 20, 2020
@Borda Borda added this to the 0.7.7 milestone May 20, 2020
@Borda Borda marked this pull request as ready for review May 20, 2020 10:11
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests show up again! 🎉

@mergify mergify bot requested a review from a team May 20, 2020 10:20
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #1900 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1900   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          74      74           
  Lines        4590    4590           
======================================
  Hits         4061    4061           
  Misses        529     529           

@mergify mergify bot requested a review from a team May 20, 2020 11:23
@williamFalcon williamFalcon merged commit c717873 into master May 20, 2020
@Borda Borda deleted the tests/fix-gh-action branch May 20, 2020 12:08
@Borda Borda modified the milestones: 0.7.7, 0.8.0 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants