Patch release for LTS series 1.9.6 [wip]

[Borda]

What does this PR do?

Seems we have prepared in the past (May 2023) this 1.9.6 release but never sent it out

Proceeding with the listed increment:
https://github.com/Lightning-AI/lightning/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3Av1.9.x+is%3Amerged

Before submitting

• Was this discussed/agreed via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

[github-actions]

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	cancelled	🚫
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	cancelled	🚫
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	cancelled	🚫
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	cancelled	🚫
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	cancelled	🚫
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	cancelled	🚫
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	cancelled	🚫
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	cancelled	🚫
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	cancelled	🚫
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	cancelled	🚫
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	cancelled	🚫
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	cancelled	🚫
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	cancelled	🚫
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	cancelled	🚫
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	cancelled	🚫
pl-cpu (macOS-11, lightning, 3.8, 1.13)	cancelled	🚫
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	cancelled	🚫
pl-cpu (windows-2022, lightning, 3.8, 1.13)	cancelled	🚫

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, src/pytorch_lightning/trainer/progress.py.

🔴 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	failure	❌

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, src/pytorch_lightning/trainer/progress.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/fabric/test.txt.

🟡 pytorch_lightning: Benchmarks

Check ID	Status
pytorch-lightning.Benchmark	no_status	❓

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, src/pytorch_lightning/trainer/progress.py.

🔴 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	cancelled	🚫
make-html (pytorch)	cancelled	🚫

These checks are required after the changes to src/pytorch_lightning/trainer/progress.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt.

🔴 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.8, 1.10, 11.3.1)	cancelled	🚫
build-cuda (3.8, 1.11, 11.3.1)	cancelled	🚫
build-cuda (3.8, 1.12, 11.3.1)	cancelled	🚫
build-cuda (3.8, 1.13, 11.6.1)	failure	❌
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.8, 1.13)	cancelled	🚫
build-NGC	cancelled	🚫
build-pl (3.8, 1.10, 11.3.1)	failure	❌
build-pl (3.8, 1.11, 11.3.1)	cancelled	🚫
build-pl (3.8, 1.12, 11.3.1)	success	✅
build-pl (3.8, 1.13, 11.6.1)	success	✅
build-xla (3.7, 1.12)	cancelled	🚫

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/fabric/test.txt.

🔴 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11)	failure	❌
fabric-cpu (macOS-11, fabric, 3.9, 1.12)	failure	❌
fabric-cpu (macOS-11, fabric, 3.10, 1.13)	failure	❌
fabric-cpu (macOS-11, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10)	failure	❌
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11)	failure	❌
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12)	failure	❌
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13)	failure	❌
fabric-cpu (ubuntu-20.04, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11)	failure	❌
fabric-cpu (windows-2022, fabric, 3.10, 1.12)	failure	❌
fabric-cpu (windows-2022, fabric, 3.10, 1.13)	cancelled	🚫
fabric-cpu (windows-2022, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13)	cancelled	🚫
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	cancelled	🚫
fabric-cpu (windows-2022, lightning, 3.8, 1.13)	cancelled	🚫

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/fabric/test.txt.

🔴 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	failure	❌

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/fabric/test.txt.

🔴 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	cancelled	🚫
app-pytest (macOS-11, app, 3.8, oldest)	failure	❌
app-pytest (macOS-11, lightning, 3.9, latest)	cancelled	🚫
app-pytest (ubuntu-20.04, app, 3.8, latest)	failure	❌
app-pytest (ubuntu-20.04, app, 3.8, oldest)	failure	❌
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	cancelled	🚫
app-pytest (windows-2022, app, 3.8, latest)	cancelled	🚫
app-pytest (windows-2022, app, 3.8, oldest)	failure	❌
app-pytest (windows-2022, lightning, 3.8, latest)	cancelled	🚫

These checks are required after the changes to requirements/app/base.txt, requirements/app/cloud.txt, requirements/app/components.txt, requirements/app/test.txt, requirements/app/ui.txt.

🔴 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	cancelled	🚫
app-examples (macOS-11, app, 3.9, oldest)	failure	❌
app-examples (macOS-11, lightning, 3.9, latest)	cancelled	🚫
app-examples (ubuntu-20.04, app, 3.9, latest)	cancelled	🚫
app-examples (ubuntu-20.04, app, 3.9, oldest)	failure	❌
app-examples (ubuntu-20.04, lightning, 3.9, latest)	cancelled	🚫
app-examples (windows-2022, app, 3.9, latest)	cancelled	🚫
app-examples (windows-2022, app, 3.9, oldest)	failure	❌
app-examples (windows-2022, lightning, 3.9, latest)	cancelled	🚫

These checks are required after the changes to requirements/app/base.txt, requirements/app/cloud.txt, requirements/app/components.txt, requirements/app/test.txt, requirements/app/ui.txt.

🟡 lightning_app: Azure

Check ID	Status
App.cloud-e2e	no_status	❓

These checks are required after the changes to requirements/app/base.txt, requirements/app/cloud.txt, requirements/app/components.txt, requirements/app/test.txt, requirements/app/ui.txt.

🔴 lightning_app: Docs

Check ID	Status
make-doctest (app)	failure	❌
make-html (app)	failure	❌

These checks are required after the changes to requirements/app/base.txt, requirements/app/cloud.txt, requirements/app/components.txt, requirements/app/test.txt, requirements/app/ui.txt.

🔴 mypy

Check ID	Status
mypy	cancelled	🚫

These checks are required after the changes to requirements/app/base.txt, requirements/app/cloud.txt, requirements/app/components.txt, requirements/app/test.txt, requirements/app/ui.txt, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, src/pytorch_lightning/trainer/progress.py.

🔴 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	failure	❌
install-pkg (ubuntu-22.04, app, 3.10)	failure	❌
install-pkg (ubuntu-22.04, fabric, 3.7)	cancelled	🚫
install-pkg (ubuntu-22.04, fabric, 3.10)	cancelled	🚫
install-pkg (ubuntu-22.04, pytorch, 3.7)	cancelled	🚫
install-pkg (ubuntu-22.04, pytorch, 3.10)	cancelled	🚫
install-pkg (ubuntu-22.04, lightning, 3.7)	cancelled	🚫
install-pkg (ubuntu-22.04, lightning, 3.10)	cancelled	🚫
install-pkg (ubuntu-22.04, notset, 3.7)	cancelled	🚫
install-pkg (ubuntu-22.04, notset, 3.10)	cancelled	🚫
install-pkg (macOS-12, app, 3.7)	failure	❌
install-pkg (macOS-12, app, 3.10)	failure	❌
install-pkg (macOS-12, fabric, 3.7)	cancelled	🚫
install-pkg (macOS-12, fabric, 3.10)	cancelled	🚫
install-pkg (macOS-12, pytorch, 3.7)	cancelled	🚫
install-pkg (macOS-12, pytorch, 3.10)	cancelled	🚫
install-pkg (macOS-12, lightning, 3.7)	failure	❌
install-pkg (macOS-12, lightning, 3.10)	failure	❌
install-pkg (macOS-12, notset, 3.7)	cancelled	🚫
install-pkg (macOS-12, notset, 3.10)	failure	❌
install-pkg (windows-2022, app, 3.7)	failure	❌
install-pkg (windows-2022, app, 3.10)	failure	❌
install-pkg (windows-2022, fabric, 3.7)	cancelled	🚫
install-pkg (windows-2022, fabric, 3.10)	cancelled	🚫
install-pkg (windows-2022, pytorch, 3.7)	cancelled	🚫
install-pkg (windows-2022, pytorch, 3.10)	cancelled	🚫
install-pkg (windows-2022, lightning, 3.7)	cancelled	🚫
install-pkg (windows-2022, lightning, 3.10)	cancelled	🚫
install-pkg (windows-2022, notset, 3.7)	cancelled	🚫
install-pkg (windows-2022, notset, 3.10)	cancelled	🚫

These checks are required after the changes to src/pytorch_lightning/trainer/progress.py, requirements/app/base.txt, requirements/app/cloud.txt, requirements/app/components.txt, requirements/app/test.txt, requirements/app/ui.txt, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/strategies.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt.

---

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 90 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

[gitguardian]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	78fa3af	tests/tests_app/utilities/test_login.py	View secret
-	Base64 Basic Authentication	78fa3af	tests/tests_app/utilities/test_login.py	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>