-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch release for LTS series 1.9.6
[wip]
#18537
Conversation
⛈️ Required checks status: Has failure 🔴
Groups summary🔴 pytorch_lightning: Tests workflowThese checks are required after the changes to 🔴 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟡 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 pytorch_lightning: Azure HPU
These checks are required after the changes to 🔴 pytorch_lightning: Docs
These checks are required after the changes to 🔴 pytorch_lightning: Docker
These checks are required after the changes to 🔴 lightning_fabric: CPU workflow
These checks are required after the changes to 🔴 lightning_fabric: Azure GPU
These checks are required after the changes to 🔴 lightning_app: Tests workflow
These checks are required after the changes to 🔴 lightning_app: Examples
These checks are required after the changes to 🟡 lightning_app: Azure
These checks are required after the changes to 🔴 lightning_app: Docs
These checks are required after the changes to 🔴 mypy
These checks are required after the changes to 🔴 installThese checks are required after the changes to Thank you for your contribution! 💜
|
a4e3ec6
to
112c4e7
Compare
fa6d7a3
to
2def1ba
Compare
18ca552
to
2def1ba
Compare
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | 78fa3af | tests/tests_app/utilities/test_login.py | View secret |
- | Base64 Basic Authentication | 78fa3af | tests/tests_app/utilities/test_login.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
What does this PR do?
Seems we have prepared in the past (May 2023) this
1.9.6
release but never sent it outProceeding with the listed increment:
https://github.com/Lightning-AI/lightning/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3Av1.9.x+is%3Amerged
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist