Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fabric internal hooks #17759

Merged

Conversation

lightningforever
Copy link
Contributor

@lightningforever lightningforever commented Jun 6, 2023

What does this PR do?

Fixes #17755

Adds Fabric-internal hooks that get called automatically.
This small selection of hooks remains undocumented/experimental for now. Subject to change in the future.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #17759 (dad3908) into master (e2986fa) will decrease coverage by 23%.
The diff coverage is 100%.

❗ Current head dad3908 differs from pull request most recent head 29a40e1. Consider uploading reports for the commit 29a40e1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #17759     +/-   ##
=========================================
- Coverage      84%      61%    -23%     
=========================================
  Files         419      414      -5     
  Lines       31644    31548     -96     
=========================================
- Hits        26680    19337   -7343     
- Misses       4964    12211   +7247     

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We could add (not now is ok) an on_after_backward hook since it's the other event we control.

@mergify mergify bot added the ready PRs ready to be merged label Jun 6, 2023
@awaelchli awaelchli enabled auto-merge (squash) June 6, 2023 14:21
@awaelchli awaelchli added this to the 2.0.x milestone Jun 6, 2023
@awaelchli awaelchli merged commit f67031b into Lightning-AI:master Jun 6, 2023
awaelchli pushed a commit that referenced this pull request Jun 7, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda pushed a commit that referenced this pull request Jun 7, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lantiga pushed a commit that referenced this pull request Jun 7, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fabric callback hooks and externally registered callbacks
4 participants