Avoid unnecessary copy saving checkpoint to fsspec files #17590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, saving large checkpoints >2GB will hit "Requested array size exceeds VM limit" error when writing to HDFS through pyarrow:
```
File "/usr/local/lib/python3.9/dist-packages/pytorch_lightning/strategies/strategy.py", line 466, in save_checkpoint
self.checkpoint_io.save_checkpoint(checkpoint, filepath, storage_options=storage_options)
File "/usr/local/lib/python3.9/dist-packages/lightning_fabric/plugins/io/torch_io.py", line 54, in save_checkpoint
_atomic_save(checkpoint, path)
File "/usr/local/lib/python3.9/dist-packages/lightning_fabric/utilities/cloud_io.py", line 72, in _atomic_save
f.write(bytesbuffer.getvalue())
File "pyarrow/io.pxi", line 359, in pyarrow.lib.NativeFile.write
File "pyarrow/error.pxi", line 113, in pyarrow.lib.check_status
OSError: [Errno 12] HDFS Write failed. Detail: [errno 12] Cannot allocate memory
```
carmocca
reviewed
May 8, 2023
awaelchli
added
checkpointing
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions. |
|
This pull request is going to be closed. Please feel free to reopen it or create a new one based on top of the 'master' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, saving large checkpoints >2GB will hit "Requested array size exceeds VM limit" error when writing to HDFS through pyarrow: