-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: auto scale batch size #1638
Merged
williamFalcon
merged 48 commits into
Lightning-AI:master
from
SkafteNicki:feature/auto_batch_size
May 9, 2020
Merged
Changes from 46 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
fbacbaf
auto batch finder
863bce9
fix styling
b004826
add description
a83417e
add different modes
78d31eb
fix copy paste error
55b6739
better organised code
0df9435
fix styling
6371521
add tests
ba98712
fix
c776fde
fix
62a7432
add some documentation
1d1a06d
added CHANGELOG.md
c46c0a7
some documentation
aa855fc
update based on review
736a8b7
Update trainer.py
williamFalcon c6bd574
Update docs/source/training_tricks.rst
williamFalcon 9f1d6b2
Update tests/trainer/test_trainer_tricks.py
williamFalcon 7dfb6c2
Update tests/trainer/test_trainer_tricks.py
williamFalcon b770f9c
Apply suggestions from code review
Borda 84bc362
use EvalModelTemplate
Borda 28779ac
param tests
Borda 929ca6f
rename
Borda 5131ade
wrap params
Borda 248f7d2
rename function
01acea9
Merge remote-tracking branch 'origin/feature/auto_batch_size' into fe…
f309bc8
rename
e5305ee
rename param
Borda 67e4324
Merge branch 'feature/auto_batch_size' of https://github.com/SkafteNi…
Borda 000c5a9
fix
Borda 3a66219
abs
Borda 9b690a4
rename
Borda f39e6d0
refactor code
4a34f7c
add docs
e56c927
merge
9d3c01e
Merge remote-tracking branch 'upstream/master' into feature/auto_batc…
33701eb
try
Borda 0572fff
arg
Borda 2d0413e
loop
Borda ce67950
exept
Borda cb490eb
loop
Borda 83dce03
drop bool
Borda a71417e
docs
Borda 0f9d195
docs
289bd34
refactor code a bit more
20e2b86
added check and test for passing dataloader to fit
522a206
styling fix
c3cdd6c
update based on review
3122cb4
Merge branch 'master' into feature/auto_batch_size
Borda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the arg
progress_bar_callback
was not used anywhere - forgotten, hope it is the right place...