Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/docker #1573

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Tests/docker #1573

merged 3 commits into from
Apr 23, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 23, 2020

What does this PR do?

Fixes #1529 building test image in advance... #1372

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added priority: 0 High priority task ci Continuous Integration labels Apr 23, 2020
@mergify mergify bot requested a review from a team April 23, 2020 14:43
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #1573 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1573   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files          68      68           
  Lines        3906    3906           
======================================
  Hits         3471    3471           
  Misses        435     435           

@Borda Borda marked this pull request as ready for review April 23, 2020 16:14
@williamFalcon
Copy link
Contributor

@Borda @justusschock killing it!

@williamFalcon williamFalcon merged commit 0b22b64 into master Apr 23, 2020
@Borda Borda deleted the tests/docker branch April 23, 2020 17:00
@Borda Borda mentioned this pull request Apr 23, 2020
5 tasks
@Borda
Copy link
Member Author

Borda commented Apr 23, 2020

as a side effect, the Drone test time is <3min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants